[ENG-10788] add nodes and preprints files reinding on account merging#11727
Open
mkovalua wants to merge 2 commits intoCenterForOpenScience:feature/pbs-26-9from
Open
[ENG-10788] add nodes and preprints files reinding on account merging#11727mkovalua wants to merge 2 commits intoCenterForOpenScience:feature/pbs-26-9from
mkovalua wants to merge 2 commits intoCenterForOpenScience:feature/pbs-26-9from
Conversation
mkovalua
changed the title
antkryt
suggested changes
May 8, 2026
|
|
||
| from django.contrib.contenttypes.models import ContentType | ||
| from osf.models import AbstractNode, Preprint | ||
| from addons.osfstorage.models import OsfStorageFile |
Contributor
There was a problem hiding this comment.
You can move django and addon imports to the top of the file. Circular import error should not occur in this case I think
Contributor
Author
There was a problem hiding this comment.
Circular import errors exist from my side for
from django.contrib.contenttypes.models import ContentType
from osf.models import AbstractNode, Preprint
antkryt
approved these changes
May 8, 2026
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
User merge does not seem to be working for files
Changes
Adding nodes and preprints files reinding on account merging
Also some updates for SHARE is good to have
CenterForOpenScience/SHARE#892
Side Effects
File indexing does not work for local setup, so maybe it is needed add something else because something may be missed because of a bit blame fix
QE Notes
CE Notes
Documentation